Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glslang: use compiler.cxx_standard 2011 #8326

Merged
merged 2 commits into from Sep 8, 2020
Merged

Conversation

chrstphrchvz
Copy link
Contributor

…instead of deprecated cxx11 1.1 portgroup

Description

Verification

Have you

  • checked your Portfile with port lint?

…instead of deprecated cxx11 1.1 portgroup
@macportsbot
Copy link

Notifying maintainers:
@eintw1ck for port glslang.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Sep 5, 2020
@chrstphrchvz
Copy link
Contributor Author

chrstphrchvz commented Sep 5, 2020

The GitHub handle in the portfile (@eintw1ck) is invalid.

Cc @jdek who submitted and has been maintaining this port.

Edit: it appears these are the same user, i.e. the maintainer updated their handle.

@macportsbot
Copy link

Travis Build #13812 Passed.

Lint results
--->  Verifying Portfile for glslang
--->  0 errors and 0 warnings found.

Port glslang success on xcode10.3. Log
Port glslang success on xcode9.4. Log
Port glslang success on xcode8.3. Log
Port glslang success on xcode7.3. Log

@chrstphrchvz
Copy link
Contributor Author

Maintainer handle updated in 81f58b7285d. @jdek, please confirm if you are still interested in maintaining this port, and if so whether the information in the portfile is now correct.

@macportsbot
Copy link

Travis Build #13834 Passed.

Lint results
--->  Verifying Portfile for glslang
--->  0 errors and 0 warnings found.

Port glslang success on xcode10.3. Log
Port glslang success on xcode9.4. Log
Port glslang success on xcode8.3. Log
Port glslang success on xcode7.3. Log

@jdek
Copy link
Contributor

jdek commented Sep 7, 2020

@chrstphrchvz I'm no longer using Macports (or even macOS) at all, so I'm not able to easily continue to maintain these ports. Feel free to take over maintainership or just remove me entirely if you'd prefer. Openmaintainer should be enough since they shouldn't really need much work, the Vulkan ports are still waiting on custom macOS SDK support in macports which I don't think has been implemented yet (the relevant ticket should still be open).

@kencu
Copy link
Contributor

kencu commented Sep 7, 2020

@chrstphrchvz - want to switch these to nomaintainer while you've got the PR and branch open?

@chrstphrchvz
Copy link
Contributor Author

@jdek Thanks for the quick response and for your past contributions. These ports will be set to nomaintainer:

glslang
spirv-tools
vulkan-headers
vulkan-loader
vulkan-tools
vulkan-validationlayers

When merging, https://trac.macports.org/ticket/60554 can be unassigned.

@macportsbot
Copy link

Travis Build #13863 Failed.

Lint results
--->  Verifying Portfile for glslang
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for spirv-tools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for vulkan-headers
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for vulkan-loader
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for vulkan-tools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for vulkan-validationlayers
--->  0 errors and 0 warnings found.

Port glslang success on xcode10.3. Log
Port spirv-tools success on xcode10.3. Log
Port vulkan-headers success on xcode10.3. Log
Port vulkan-loader fail on xcode10.3. Log
Port vulkan-tools success on xcode10.3. Log
Port vulkan-validationlayers success on xcode10.3. Log
Port glslang success on xcode9.4. Log
Port spirv-tools success on xcode9.4. Log
Port vulkan-headers success on xcode9.4. Log
Port vulkan-loader fail on xcode9.4. Log
Port vulkan-tools success on xcode9.4. Log
Port vulkan-validationlayers success on xcode9.4. Log
Port glslang success on xcode8.3. Log
Port spirv-tools success on xcode8.3. Log
Port vulkan-headers success on xcode8.3. Log
Port vulkan-loader fail on xcode8.3. Log
Port vulkan-tools success on xcode8.3. Log
Port glslang success on xcode7.3. Log
Port spirv-tools success on xcode7.3. Log
Port vulkan-headers success on xcode7.3. Log
Port vulkan-loader's dependencies fail on xcode7.3. Log
Port vulkan-tools's dependencies fail on xcode7.3. Log
Port vulkan-validationlayers's dependencies fail on xcode7.3. Log

@macportsbot
Copy link

Travis Build #13864 Failed.

Lint results
--->  Verifying Portfile for glslang
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for spirv-tools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for vulkan-headers
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for vulkan-loader
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for vulkan-tools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for vulkan-validationlayers
--->  0 errors and 0 warnings found.

Port glslang success on xcode10.3. Log
Port spirv-tools success on xcode10.3. Log
Port vulkan-headers success on xcode10.3. Log
Port vulkan-loader fail on xcode10.3. Log
Port vulkan-tools success on xcode10.3. Log
Port vulkan-validationlayers success on xcode10.3. Log
Port glslang success on xcode9.4. Log
Port spirv-tools success on xcode9.4. Log
Port vulkan-headers success on xcode9.4. Log
Port vulkan-loader fail on xcode9.4. Log
Port vulkan-tools success on xcode9.4. Log
Port vulkan-validationlayers success on xcode9.4. Log
Port glslang success on xcode8.3. Log
Port spirv-tools success on xcode8.3. Log
Port vulkan-headers success on xcode8.3. Log
Port vulkan-loader fail on xcode8.3. Log
Port vulkan-tools success on xcode8.3. Log
Port vulkan-validationlayers success on xcode8.3. Log
Port glslang success on xcode7.3. Log
Port spirv-tools's dependencies fail on xcode7.3. Log
Port vulkan-headers success on xcode7.3. Log
Port vulkan-loader's dependencies fail on xcode7.3. Log
Port vulkan-tools's dependencies fail on xcode7.3. Log
Port vulkan-validationlayers's dependencies fail on xcode7.3. Log

@kencu kencu merged commit 5f2f96a into macports:master Sep 8, 2020
@chrstphrchvz chrstphrchvz deleted the patch-13 branch September 9, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port
4 participants