Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of cleanups and restructuring to pave way for Django 1.6/1.7 #80

Merged
merged 11 commits into from Jan 30, 2016

Conversation

mithro
Copy link
Member

@mithro mithro commented Dec 22, 2014

No description provided.

@mithro
Copy link
Member Author

mithro commented Dec 22, 2014

@funkybob Do you remember how far you got with doing this? @ajitmathew is interested in continuing this work

@funkybob
Copy link
Contributor

A lot of this was just basic clean ups.
1> apply flake8
2> apply best practices [like using staticfiles]
3> remove bad stuff [like passing locals() to templates]

@ApsOps ApsOps self-assigned this Dec 23, 2014

if __name__ == "__main__":
execute_manager(settings)
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "website.settings")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails since there is no __init__.py in website/.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a __init__.py, since 70de77d

@ApsOps
Copy link
Member

ApsOps commented Jan 8, 2015

south is no longer needed in Django>=1.7


# Absolute path to the directory static files should be collected to.
# Don't put anything in this directory yourself; store your static files
# in apps' "static/" subdirectories and in STATICFILES_DIRS.
# Example: "/home/media/media.lawrence.com/static/"
STATIC_ROOT = '/tmp/timvideos-static'
STATIC_ROOT = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required by staticfiles app.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally you'd have a production settings file import all these settings, and override this.

Leaving this blank avoids problems in development.

@mithro mithro assigned micolous and unassigned ApsOps Jan 15, 2015
@mithro
Copy link
Member Author

mithro commented Jan 15, 2015

If you get some time, it would be cool for you to take a look at this @micolous

@mithro mithro merged commit 3c823d8 into timvideos:master Jan 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants