Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page_description and page_keywords md meta to mkdocs html template #5516

Merged
1 commit merged into from May 1, 2014

Conversation

SvenDowideit
Copy link
Contributor

Docker-DCO-1.1-Signed-off-by: Sven Dowideit SvenDowideit@fosiki.com (github: SvenDowideit)

Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@fosiki.com> (github: SvenDowideit)
@SvenDowideit
Copy link
Contributor Author

@jamtur01 @ostezer this will render the .md file's

page_description: some stuff
page_keywords: list, of, words to, use

@SvenDowideit
Copy link
Contributor Author

addresses the technical part of #5360

@samalba
Copy link
Contributor

samalba commented May 1, 2014

LGTM

cc @dhrp (this is to fix SEO on the doc site)

Thanks @SvenDowideit !

@jamtur01
Copy link
Contributor

jamtur01 commented May 1, 2014

LGTM

@ghost
Copy link

ghost commented May 1, 2014

LGTM.
However, this does not close the issue #5360.
This just solves the technical problem.
We still need to amend the docs to have better and preferably useful descriptions and keywords.
Please do not close the issue.
Merging.

ghost pushed a commit that referenced this pull request May 1, 2014
add page_description and page_keywords md meta to mkdocs html template
@ghost ghost merged commit c52bb90 into moby:master May 1, 2014
@dhrp
Copy link
Contributor

dhrp commented May 1, 2014

Thanks!

@SvenDowideit SvenDowideit deleted the docs-meta-rendering branch June 27, 2014 04:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants