Implement String.new encoding optional argument #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| replace arg unless undefined.equal?(arg) | ||
| self.force_encoding(encoding) if encoding |
There was a problem hiding this comment.
What's the reason for this using force_encoding and not encode!?
There was a problem hiding this comment.
I was not aware of encode! thats the only reason
Should I change it to use encode! ?
There was a problem hiding this comment.
After digging into mri's c code @yorickpeterse and me came to the conclusion to use force_encoding here.
MRI is using rb_enc_associate: https://github.com/ruby/ruby/blob/trunk/string.c#L1354
Which is also used in force_encoding: https://github.com/ruby/ruby/blob/trunk/string.c#L8671
tak1n
added a commit
that referenced
this pull request
Jan 21, 2016
Implement String.new encoding optional argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3559