Replace CoffeeScript block into JavaScript in Views. #9819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example view: shared/issuable/_context CoffeeScript: 190ms JavaScript: 19.7ms
|
Fascinating. /cc: @randx |
Wow thats amazing. I did not know that. |
|
Especially benchmarks numbers are big |
dzaporozhets
added a commit
that referenced
this pull request
Nov 10, 2015
Replace CoffeeScript block into JavaScript in Views.
|
👍 |
|
awesome! |
This was referenced Jan 11, 2016
dzaporozhets
pushed a commit
that referenced
this pull request
Jan 14, 2016
* master: (143 commits) Only load autocomplete data when actually needed Check for current user Add pencil icon to edit group settings Issue #5817 wording of the web hooks updated on issue and merge events use JavaScript instead of CoffeeScript in Views, the reason #9819 Before project save ensure that a runners_token exists Fix Error 500 when visiting build page of project with nil runners_token Remove outdated gitlab-git-http-server reference from Install doc Fix typo in build page of projects Update docs for shared runner default settings Disable "Already Blocked" button in admin abuse report page Add CHANGELOG entry for reply-by-email fix Use WOFF versions of SourceSansPro Clean up document on adding users to a project Refactor ZenMode Fix caching issue where build status was not updating in project dashboard Add a CHANGELOG entry for The Most Important Feature of All Time(TM) changes verb `references` to noun `reference`. fixes new branch button positioning, when visible and not visible container DRY up upload and download services ...
|
Saves 10x time. Fascinating! |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CoffeeScript in View will compile again and again in each requests, because there have variables, Rails view can't caching them.
:coffeescript projectId = #{@project.id}By my benchmark test for
shared/issuable/_contextrender time:190ms19.7msI have enabled all caching config like production environment.