@brixen I fiddled around with this last week but wasn't really sure about our current setup to begin with. For example, when keyword arguments are present we seem to allocate a Hash (basically the old options = {} argument) instead of using proper keyword arguments.

Since I'm not really sure about things I'll leave this one up to you.

@ahmadsherif I'll pull the AST stuff into https://github.com/rubinius/rubinius-code ASAP and we can work from there.

@yorickpeterse there's no such thing as proper keyword arguments, it's janky Hash all the way down in Ruby. We may be able to do some optimizations once we start cleaning up the instruction set.

With the stuff pulled in, can this be merged?

@yorickpeterse the changes to the functions need to be represented in the JIT as well. A good first step is writing JIT specs for these cases.

s/functions/instructions/

@brixen Apparently JIT is disabled for methods with keyword arguments, should we fix this first? I would like to try but I don't know what's "compile policy checks" :).

@ahmadsherif sorry, somehow I didn't see your last message. I merged this since the JIT is disabled right now and we'll fix this up as part of re-enabling the JIT. Also, it's a good time to look at integrating keywords into the Arguments structure so eg we can optimize sites that have explicit keywords with the inline cache mechanism to pass the arguments straight through when they are not captured in a kwrest argument.