Fix issue in slice_(after|before) when iterator method yields more than one value #3584
+20
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I took some time to look at the issue that was reported by @ioquatix in #3554 (comment) and I found out that it affects all our slice_* methods. Unfortunately, I didn't spend much time to figure out how to fix this but I will come back to this when I have the time. As for this PR, I hope someone can give me some feedback with regard to the clarity of the description of the specs and the readability of the specs. I am not sure if the spec is readable enough in this current state.