rubinius · Jan 25, 2016 · Jan 25, 2016
Showing with 8 additions and 3 deletions.

+2 −3 kernel/common/array.rb

+6 −0 spec/ruby/core/array/product_spec.rb
diff --git a/kernel/common/array.rb b/kernel/common/array.rb
@@ -1144,9 +1144,8 @@ def product(*args)
     outer_lambda.call([])
 
     if block_given?
-      block_result = self
-      result.each { |v| block_result << yield(v) }
-      block_result
+      result.each { |v| yield(v) }
+      self
     else
       result
     end

diff --git a/spec/ruby/core/array/product_spec.rb b/spec/ruby/core/array/product_spec.rb
@@ -41,6 +41,12 @@
       acc.should be_empty
     end
 
+    it "returns self" do
+      a = [1, 2, 3].freeze
+
+      a.product([1, 2]) { |p| p.first }.should == a
+    end
+
     it "will ignore unreasonable numbers of products and yield anyway" do
       a = (0..100).to_a
       lambda do