Fix #2223 -- encode commands in github_deploy

Kwpolska · Kwpolska · commit 3f7a1b76ad07 · 2016-01-22T19:33:13.000+01:00
Signed-off-by: Chris Warrick &lt;kwpolska@gmail.com&gt;
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -14,6 +14,7 @@ Features
 Bugfixes
 --------
 
+* Fix ``github_deploy`` on Windows (Issue #2223)
 * Avoid some random file rebuilds (Issue #2220)
 * Honor ``MATHJAX_CONFIG``
 * Display tags and archives in a unified format, with the date on the
diff --git a/nikola/plugins/command/github_deploy.py b/nikola/plugins/command/github_deploy.py
@@ -49,7 +49,10 @@ def uni_check_output(*args, **kwargs):
 def check_ghp_import_installed():
     """Check if ghp-import is installed."""
     try:
-        subprocess.check_output(['ghp-import', '-h'])
+        if os.name == 'nt':
+            subprocess.check_output([b'ghp-import', b'-h'])
+        else:
+            subprocess.check_output(['ghp-import', '-h'])
     except OSError:
         # req_missing defaults to `python=True` — and it’s meant to be like this.
         # `ghp-import` is installed via pip, but the only way to use it is by executing the script it installs.
@@ -109,6 +112,8 @@ def _execute(self, options, args):
     def _run_command(self, command, xfail=False):
         """Run a command that may or may not fail."""
         self.logger.info("==> {0}".format(command))
+        if os.name == 'nt':
+            command = [i.encode('ascii', errors='replace') for i in command]
         try:
             subprocess.check_call(command)
             return 0
