Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake Xcode derivation #12604

Closed
wants to merge 3 commits into from
Closed

Fake Xcode derivation #12604

wants to merge 3 commits into from

Conversation

pikajude
Copy link
Contributor

This makes building packages that expect an Xcode installation to exist both easier to do and easier to debug.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @wkennington, @svanderburg and @flosse to be potential reviewers

@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label Jan 25, 2016
@domenkozar
Copy link
Member

Could we keep such files outside of nixpkgs repository? It's already really huge.

@@ -152,7 +152,6 @@
joachifm = "Joachim Fasting <joachifm@fastmail.fm>";
joamaki = "Jussi Maki <joamaki@gmail.com>";
joelmo = "Joel Moberg <joel.moberg@gmail.com>";
joelteon = "Joel Taylor <me@joelt.io>";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just broke hydra's evaluation of a bunch of other packages that refer to joelteon. Might want to fix those, too!

@copumpkin
Copy link
Member

I'll take a closer look later, but @domenkozar which large files are you talking about?

@domenkozar
Copy link
Member

@copumpkin nixpkgs is 450MB, let's make sure we don't add sourcecode to it. I'd just create a github repository and use fetchFromGithub to get sources.

@copumpkin
Copy link
Member

You talking about the small shell scripts in this commit though? This
doesn't seem like a particularly bad offender.

I also share concerns about the repo size, but the giant autogenerated
package bundles seem like the bigger concern than one-off shell scripts. We
need to get import-from-derivation working properly and use it all over the
place!
On Mon, Jan 25, 2016 at 08:50 Domen Kožar notifications@github.com wrote:

@copumpkin https://github.com/copumpkin nixpkgs is 450MB, let's make
sure we don't add sourcecode to it. I'd just create a github repository and
use fetchFromGithub to get sources.


Reply to this email directly or view it on GitHub
#12604 (comment).

@domenkozar
Copy link
Member

@copumpkin well this is how code starts to grow around :) I think all of those scrips should be moved, but we have to also make sure we don't add more.

@copumpkin
Copy link
Member

@domenkozar sure, but I'd focus my shrinking efforts on the thing adding 99% of the new space automatically rather than the thing adding a kilobyte or two at a time, with human intervention. Humans are pretty bad at producing tons of data by hand. There's a cost to moving small scripts out of the repo (maintaining the hashes and so on), and when they're (small) core build scripts used by everything else, keeping them in the repo doesn't seem that bad to me. Or would you move cc-wrapper and the stdenv's setup.sh out of the repo too?

@domenkozar
Copy link
Member

Sure, but expect me to comment on next commit that finds out this gluecode isn't enough :)

@pikajude
Copy link
Contributor Author

@copumpkin fixed

@domenkozar This derivation is 9.7KB in total and uses substituteAll pretty extensively, so my worry is that it wouldn't be as simple as it seems to break it out into its own package.

@@ -0,0 +1,17 @@
fooPhase() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we name this something like xcodePatchPhase?

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2016

is this still relevant?

@periklis
Copy link
Contributor

periklis commented Mar 9, 2017

If we're going to merge this, following packages should be migrated to use nix-code as a dependency too:
Applications/audio/chuck/default.nix

@copumpkin
Copy link
Member

I think @matthewbauer's xcbuild and nixpkgs-based SDK for it cover most of the use cases for this, right?

@wizeman wizeman closed this Oct 30, 2017
@wizeman wizeman deleted the fake-xcode branch October 30, 2017 15:20
@grahamc grahamc restored the fake-xcode branch October 30, 2017 15:53
@copumpkin
Copy link
Member

@wizeman @orivej another example

@pikajude you still interested in pushing this?

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

Are there any updates on this pull request, please?

@pikajude pikajude closed this Jan 30, 2020
@lheckemann lheckemann deleted the fake-xcode branch July 13, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet