New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake Xcode derivation #12604
Fake Xcode derivation #12604
Conversation
By analyzing the blame information on this pull request, we identified @wkennington, @svanderburg and @flosse to be potential reviewers |
Could we keep such files outside of nixpkgs repository? It's already really huge. |
@@ -152,7 +152,6 @@ | |||
joachifm = "Joachim Fasting <joachifm@fastmail.fm>"; | |||
joamaki = "Jussi Maki <joamaki@gmail.com>"; | |||
joelmo = "Joel Moberg <joel.moberg@gmail.com>"; | |||
joelteon = "Joel Taylor <me@joelt.io>"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just broke hydra's evaluation of a bunch of other packages that refer to joelteon
. Might want to fix those, too!
I'll take a closer look later, but @domenkozar which large files are you talking about? |
@copumpkin nixpkgs is 450MB, let's make sure we don't add sourcecode to it. I'd just create a github repository and use fetchFromGithub to get sources. |
You talking about the small shell scripts in this commit though? This I also share concerns about the repo size, but the giant autogenerated
|
@copumpkin well this is how code starts to grow around :) I think all of those scrips should be moved, but we have to also make sure we don't add more. |
@domenkozar sure, but I'd focus my shrinking efforts on the thing adding 99% of the new space automatically rather than the thing adding a kilobyte or two at a time, with human intervention. Humans are pretty bad at producing tons of data by hand. There's a cost to moving small scripts out of the repo (maintaining the hashes and so on), and when they're (small) core build scripts used by everything else, keeping them in the repo doesn't seem that bad to me. Or would you move cc-wrapper and the stdenv's setup.sh out of the repo too? |
Sure, but expect me to comment on next commit that finds out this gluecode isn't enough :) |
@copumpkin fixed @domenkozar This derivation is 9.7KB in total and uses substituteAll pretty extensively, so my worry is that it wouldn't be as simple as it seems to break it out into its own package. |
@@ -0,0 +1,17 @@ | |||
fooPhase() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we name this something like xcodePatchPhase?
is this still relevant? |
If we're going to merge this, following packages should be migrated to use |
I think @matthewbauer's |
Are there any updates on this pull request, please? |
This makes building packages that expect an Xcode installation to exist both easier to do and easier to debug.