Properly check for write errors in metrics FileEmitter.

brixen · brixen · commit 49181363fdef · 2016-01-24T21:14:38.000-08:00
diff --git a/vm/metrics.cpp b/vm/metrics.cpp
@@ -73,7 +73,7 @@ namespace rubinius {
         }
       }
 
-      if(write(fd_, "\n", 1)) {
+      if(write(fd_, "\n", 1) < 0) {
         logger::error("%s: unable to write file metrics", strerror(errno));
       }
     }
@@ -97,7 +97,7 @@ namespace rubinius {
           }
         }
 
-        if(write(fd_, "\n", 1)) {
+        if(write(fd_, "\n", 1) < 0) {
           logger::error("%s: unable to write file metrics", strerror(errno));
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ namespace rubinius {`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
`76`		`- if(write(fd_, "\n", 1)) {`
	`76`	`+ if(write(fd_, "\n", 1) < 0) {`
`77`	`77`	`logger::error("%s: unable to write file metrics", strerror(errno));`
`78`	`78`	`}`
`79`	`79`	`}`
`@@ -97,7 +97,7 @@ namespace rubinius {`
`97`	`97`	`}`
`98`	`98`	`}`
`99`	`99`
`100`		`- if(write(fd_, "\n", 1)) {`
	`100`	`+ if(write(fd_, "\n", 1) < 0) {`
`101`	`101`	`logger::error("%s: unable to write file metrics", strerror(errno));`
`102`	`102`	`}`
`103`	`103`	`}`