-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truffle ropes #3623
Merged
Merged
Truffle ropes #3623
+2,966
−1,121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Strings are now backed by ropes.
…h codes have already been calculated. This could help avoid a length byte walk.
We probably need something more robust to various attacks, but we definitely shouldn't be creating a temporary ByteList to get a hash code.
…filling each descendent's byte[] as well.
* Unified with the String#data method. * Used Rubinius::ByteArray and removed our Rubinius::StringData shim. * Cached value in String DynamicObject and invalidate on Rope update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR that combines the work from two previously closed, but not merged PRs (#3605 and #3619). I've simply combined them since the original PR wasn't sufficiently far enough along to merge and I wanted the work in the second one to be independently reviewable.