fix(files): Remove use of localstorage. #217
Conversation
|
I think thats good for now. It would be cool to list things inside |
|
@whyrusleeping why don't you open an issue for that :P |
|
How does it list all? |
|
👍 for removing local storage |
|
@jbenet this is how it does it currently:
(that was like this before) would |
As discussed this removes the local tab in favor of the all and pinned tabs. Also makes the drop area for files visible at all times. Closes #32
dignifiedquire
force-pushed
the
fix/remove-local-storage
branch
from
ab31d4a to
c3d04b5
Compare
|
this is fine i think |
|
|
LGTM from a UX perspective |
| @@ -33,36 +31,53 @@ default class Files extends React.Component { | |||
| clearInterval(this.pollInterval) | |||
| } | |||
|
|
|||
| getFiles = () => { | |||
| getFiles () { | |||
There was a problem hiding this comment.
isn't there a missing = and => here, even if just for consistency
There was a problem hiding this comment.
No, the important part is that these are two different sorts of methods, if you declare them like this:
getFiles () {
}it's a regular method. If you declare it like this:
getFiles = () => {
}it means that in addition it is bound i.e. getFiles = getFiles.bind(this) where this is the instance of the class.
As this method is not used passed somewhere there is no need to bind it.
|
Other than the one comment, LGTM :) nice! |
fix(files): Remove use of localstorage.
As discussed this removes the local tab in favor of the
all and pinned tabs. Also makes the drop area for files
visible at all times.
Closes #32
@jbenet @whyrusleeping please take a look if this is okay for listing files for now or if there are better methods.