-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in method calling on Java objects in 9.0.5.0 (field not calling getField for JDBC object) #3622
Comments
@jeremyevans this is kind of intended ... see discussion at: #3262 |
I've already committed a work around to Sequel about a half hour ago. I don't disagree with the logic in #3262 in regards to removing the feature, but I think it may have been better to do it in 9.1 as opposed to 9.0.5.0, especially since this was not mentioned as a backwards compatibility issue in the release notes. It is true that #3262 is mentioned in the release notes, but unless you expect all users to read every referenced note, it's unlikely someone would think it affected backwards compatibility. |
yeah, did a really bad job around this one. simply got carried away that it can not be used as the writer version would look completely weird and the feature wasn't documented at all (only normal getter -> reader mappings were used in samples). sorry again - backwards compat is crucial and this should have printed a deprecation warning first. and as you said removal would have been fine in 9.1.0 .... 😭 |
This just bit us too over in shoes/shoes4#1217 (cc @plexus) I guess I'll check the Mailing list and notify it too if that hasn't happened yet :| Yep 9.1.0 would have been better, but there's not much good in regrets :) Also in favor of the change, was a bit too much magic maybe. Cheers + thanks for your work as always, |
Just one more "me too" 😄 We had to rewrite our use of the POI API. |
Running Sequel's specs with jdbc-postgres on JRuby 9.0.5.0 results in nearly all failures of the type:
All tests pass in JRuby 9.0.4.0.
field
should work here, calling thegetField
Java function, see the PostgreSQL JDBC API: https://jdbc.postgresql.org/development/privateapi/org/postgresql/jdbc4/Jdbc4ResultSetMetaData.htmlChanging the ruby code to call
getField
instead offield
(and alsogetOID
instead ofoid
on the object returned bygetField
) does fix the issues, but my understanding is that JRuby should work withfield
andoid
, and that this is a regression in JRuby.The text was updated successfully, but these errors were encountered: