Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses ticket #1965 #2077

Merged
merged 1 commit into from Feb 28, 2016
Merged

Addresses ticket #1965 #2077

merged 1 commit into from Feb 28, 2016

Conversation

haninaguib
Copy link

I am planing on integrating hawtio into a monitoring application we have and wanted the ability to create links that would open up hawtio and automatically connect to specific servers being monitored.

With this change I am able to do so by creating links in this format
/hawtio/index.html#/jvm/connect?name={name}&host={host}&port={port}&path={path}&userName={userName}&password={password}

This is very hacky and I am sure one of you could improve it, I have only started looking at hawtio today and javascript/typescrypt is not something I am too familiar with.

@davsclaus
Copy link
Member

Yeah this seems not so hacky after all. Though the one thing is that the password would be submitted in clear-text.

@haninaguib
Copy link
Author

In my use case I dont use username/password (all agents are on unexposed ports within a VPC)
But maybe username & password should come in via a basic auth header instead of url params.

@davsclaus
Copy link
Member

Yeah though if you omit username and password then whatever auth is used on that remote jvm ought to kick-in, eg show a login dialog if basic auth etc.

davsclaus added a commit that referenced this pull request Feb 28, 2016
@davsclaus davsclaus merged commit 80183ee into hawtio:master Feb 28, 2016
var autoconnect = $location.search();
if (typeof autoconnect != 'undefined' && typeof autoconnect.name != 'undefined') {
var conOpts = Core.createConnectOptions({
scheme: 'http',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be possible to change this feature to allow to set the scheme as well, since now auto connect link limits to only http connections. It would be good to have scheme parameter in url as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sure you are welcome to do a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants