Various fixes to localsearch plugin #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwax
commented
Jan 22, 2016
gwax
commented
- fixed tag that should be a <script> tag
- localsearch now properly applies filters to assets and generated json
- localsearch caching should have fewer false negatives
added 6 commits
January 21, 2016 21:40
|
Awesome, thanks for the fixes! |
ralsina
added a commit
that referenced
this pull request
Jan 22, 2016
Various fixes to localsearch plugin
|
I had a branch pending that also touched this plugin, and I had forgotten to merge it. Can you check that all your fixes are still applied? |
|
Looks all good to me. |
|
cool, thanks. On Fri, Jan 22, 2016 at 2:32 PM George Leslie-Waksman <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.