buildbot: fix .withPlugins to propagate inputs #23646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before I was just grabbing the immediate dependencies. I _think_ this will do the right thing by using the pre-existing setup hook to avoid having to compute the transitive closure myself.
|
@copumpkin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nand0p to be a potential reviewer. |
|
I'm actually using this just fine in my local deployment so I'm going to merge and then can fix if either of you find issues with it. I'm pretty sure it does most of what I want, at the least 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I was just grabbing the immediate dependencies. I think this will do the right thing by using the pre-existing setup hook to avoid having to compute the transitive closure myself.
cc @FRidh @nand0p