pythonPackages.lit: init at 0.5 #23643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Mar 8, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -8242,6 +8242,25 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| lit = buildPythonApplication rec { | |||
There was a problem hiding this comment.
Oh, my mistake. Will fix shortly.
pkgs/top-level/python-packages.nix
Outdated
| disabled = isPy3k; | ||
|
|
||
| src = pkgs.fetchurl { | ||
| url = "https://files.pythonhosted.org/packages/5b/a0/dbed2c8dfb220eb9a5a893257223cd0ff791c0fbc34ce2f1a957fa4b6c6f/lit-0.5.0.tar.gz"; |
There was a problem hiding this comment.
I'm not sure how to make fetchPypi work here--all the variants AFAICT give a 404 :/. I'm pushing what I have to demonstrate. Not sure why this package would be different than others?
|
I've pushed c766960. |
|
@FRidh great, thank you! It's curious that it no longer 404's! .. after some investigation it appears this is because the version needed to be "0.5.0" not simply "0.5". D'oh. Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
'lit' is handy for running test-suites of various LLVM projects.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)