pyrax: 1.8.2 -> 1.9.8 #23649
Merged
pyrax: 1.8.2 -> 1.9.8 #23649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Mar 9, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -21557,18 +21557,23 @@ in { | |||
| rackspace-novaclient = callPackage ../development/python-modules/rackspace-novaclient.nix { }; | |||
|
|
|||
| pyrax = buildPythonPackage rec { | |||
There was a problem hiding this comment.
Could also move this package to an external file?
Mic92
reviewed
Mar 9, 2017
pkgs/top-level/python-packages.nix
Outdated
| # no good reason given in commit why limited, and seems to work | ||
| patchPhase = '' | ||
| substituteInPlace "setup.py" \ | ||
| --replace "==2.27.0" "" |
There was a problem hiding this comment.
It would be also interesting what is before == for later updates.
Note that I package a number of dependencies that make no sense outside of rackspace-novaclient. I don't want to pollute the main namespace with those packages.
|
I also made the unit tests working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I want to write a nixops adapter for rackspace because they sponsor haskell infrastructure which currently runs on nixos.
This package is a bit weird because AFAICT the dependencies don't make any sense outside of pyrax but happy to make top-level as if necessary.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)