The surface navball #1263
Merged
The surface navball #1263
+87
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Mar 15, 2017
| @@ -70,6 +71,7 @@ using physics::KeplerianElements; | |||
| using physics::RotatingBody; | |||
| using physics::RigidMotion; | |||
| using physics::RigidTransformation; | |||
| using physics::BodySurfaceFrameField; | |||
| auto plotting_frame_as_body_surface_dynamic_frame = | ||
| dynamic_cast<BodySurfaceDynamicFrame<Barycentric, Navigation>*>( | ||
| &*plotting_frame_); | ||
| if (plotting_frame_as_body_surface_dynamic_frame != nullptr) { |
| @@ -908,24 +910,29 @@ std::unique_ptr<FrameField<World, Navball>> Plugin::NavballFrameField( | |||
| public: | |||
There was a problem hiding this comment.
Add TODO(phl): Clean up this mess!.
| CoordinateFrameField<Navigation, RightHandedNavball>>(), | ||
| sun_world_position); | ||
| std::unique_ptr<FrameField<Navigation, RightHandedNavball>> frame_field; | ||
| auto plotting_frame_as_body_surface_dynamic_frame = |
| @@ -42,8 +42,6 @@ public partial class PrincipiaPluginAdapter | |||
| private IntPtr plugin_ = IntPtr.Zero; | |||
|
|
|||
| private bool display_patched_conics_ = false; | |||
| [KSPField(isPersistant = true)] | |||
| private bool fix_navball_in_plotting_frame_ = true; | |||
There was a problem hiding this comment.
This reminds me that I'll need to update the Wiki to reflect the new UI.
pleroy
added a commit
to pleroy/Principia
that referenced
this pull request
Mar 15, 2017
eggrobin
added a commit
that referenced
this pull request
Mar 15, 2017
Comments on #1263 and make the tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is flipped, as it happens.