Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackage.firebase-tools: init at 3.9.1 #23931

Closed
wants to merge 1 commit into from

Conversation

kirelagin
Copy link
Member

No description provided.

@kirelagin
Copy link
Member Author

kirelagin commented Mar 15, 2017

I should probably note that I am completely new to all this nodejs business (both nix-related and in general). I’m a little bit worried that this commit also updates lots of other packages and I don’t know how bad that is, but, well, I followed the README.

Speaking about firebase-tools, I verified that it properly communicates with the server, lists projects and successfully deployed my website.

@@ -15,6 +15,7 @@
, "eslint"
, "emojione"
, "fetch-bower"
, "firebase-tools"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an alias in all-packages.nix would be nice:

  firebase-tools = nodePackages.firebase-tools;

@kirelagin kirelagin changed the title nodePackage.firebase-tools: init at 3.5.0 nodePackage.firebase-tools: init at 3.6.0 Apr 6, 2017
@kirelagin
Copy link
Member Author

Are node packages dead? That’s sad 😞.

@kirelagin kirelagin changed the title nodePackage.firebase-tools: init at 3.6.0 nodePackage.firebase-tools: init at 3.9.1 Jul 9, 2017
@kirelagin
Copy link
Member Author

Hiiiii ✋

@wizzup
Copy link
Contributor

wizzup commented Aug 7, 2017

Seem like nobody have solution for generate.sh mess with these two files,

pkgs/development/node-packages/node-packages-v4.nix
pkgs/development/node-packages/node-packages-v6.nix

#27952 #23771 #25770 #26018

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2017

Closing this for now because this is way too much LOC to add to nixpkgs for a single package. Plus v3.9.1 is already obsoleted upstream anyway.
But feel free to reopen or come back with a new PR if you work on this again. :)

@c0bw3b c0bw3b closed this Nov 13, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 14, 2017

The lines of code might be not only only accounted for the tool itself but also updating other packages.

@kirelagin
Copy link
Member Author

The fact that I get back to this PR relatively rarely doesn’t meen that I don’t want firebase-tools in nixpkgs. I still do. If all the PRs adding node expressions are going to be closed as “too much LOC” then I’m not sure how to proceed.

@wizzup
Copy link
Contributor

wizzup commented Dec 18, 2017

I don't have the authority to decide how to fix node-packages-v*.nix but if you want to try reducing the diff, try checkout latest version of these files from master and rerun generate.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants