Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.zeep: init at 1.1.0 #23934

Merged
merged 1 commit into from Mar 18, 2017
Merged

pythonPackages.zeep: init at 1.1.0 #23934

merged 1 commit into from Mar 18, 2017

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 15, 2017

Motivation for this change

Handy library for accessing SOAP services with Python.

Works with both Python 2.7 and 3.5.

Tests

Tests won't work under Python 3.5 due to the testtools dependency. Under Python 2.7 some dependencies can be bumped by a few versions to make it install, but then the test runner wasn't finding the tests and it all seemed too hard to bother.

Tested build with

nix-shell -E 'with import ./. {}; (pkgs.python35.withPackages (ps: [ps.zeep])).env'

and then ran the example from the home page.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@@ -32014,6 +32014,40 @@ EOF
yenc = callPackage ../development/python-modules/yenc {
};

zeep = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a new policy for python to put python packages into a separate file and only reference them here:

See also:

$ chromium "file://$(nix-build --no-out-link doc)//share/doc/nixpkgs/manual.html#contributing-guidelines"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mic92 , sorry I didn't realise. I have pushed a new version. And tests now work with 2.7 (but not 3.5 - testtools dep).

Works with both Python 2.7 and 3.5.

Tests won't work under Python 3.5 due to the testtools dependency.
@7c6f434c 7c6f434c merged commit c320267 into NixOS:master Mar 18, 2017
@rvl
Copy link
Contributor Author

rvl commented Mar 19, 2017

Thanks @Mic92 & @7c6f434c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants