Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emby: 3.2.5 -> 3.2.8 #24168

Merged
merged 1 commit into from Mar 22, 2017
Merged

emby: 3.2.5 -> 3.2.8 #24168

merged 1 commit into from Mar 22, 2017

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Mar 21, 2017

Motivation for this change

Several bugs fixed.

Would be nice to include this in 17.03 (@globin)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@fadenb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kevincox to be a potential reviewer.

@dtzWill
Copy link
Member

dtzWill commented Mar 21, 2017

LGTM, haha I have the same commit/hash locally and I've been using it for a few days now (sorry didn't upstream, was debugging the DLNA stuff first). Seems to work just as well as the previous version, only without nagging me to update! :).

@kevincox
Copy link
Contributor

👍 Looks good for merging.

@joachifm joachifm merged commit d693ffd into NixOS:master Mar 22, 2017
@globin globin deleted the emby_3.2.8 branch March 22, 2017 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants