Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Design: download for Save visible and Save full page #2157

Closed
ianb opened this issue Feb 9, 2017 · 12 comments
Closed

Design: download for Save visible and Save full page #2157

ianb opened this issue Feb 9, 2017 · 12 comments
Assignees
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Feb 9, 2017

Right now we have a noticeable inconsistency where you can download a selection, but not the other options.

@ianb ianb added the needs:UX label Feb 9, 2017
@ianb ianb added this to the Page Shot in 54 milestone Feb 15, 2017
@johngruen
Copy link
Contributor

I think this is a stretch based on the current flows i've seen. Would be nice to resolve, but i don't think it blocks launch.

@johngruen
Copy link
Contributor

This was my idea...asking design to go ahead and take a look
select list shot button 1
select list shot button 2

@ianb
Copy link
Contributor Author

ianb commented Mar 21, 2017

I'm having a hard time putting my finger on why, but in this model it feels like "Save full page" is a modifier on the selection action, as opposed to an entirely separate action. Maybe because it looks like a select box and so it's not obvious that each item is actually an action with immediate effects.

@ChenMorpheus
Copy link

We tried several mockups and decided to go this proposal since it's more consistent to the current regional crop. In short, when users choose to have a full page shot, we offer them the preview of the final result to decide if download or crop. Please find the link below for the prototype and let us know your thoughts or the feasibility, thanks.

https://mozilla.invisionapp.com/share/BJB0YYB9W#/225402436_2-1_Shot_page_right_side_menu_-2-

2 5 save fullpage

@dannycoates
Copy link
Contributor

Should this still be in Milestone 54?

@ghost ghost modified the milestones: Next Tasks, Screenshots in 54 May 1, 2017
@johngruen
Copy link
Contributor

@ianb is this feasible? would be a good follow on in 56?

@ianb
Copy link
Contributor Author

ianb commented May 30, 2017

Outside of the UI implementation itself, implementing download-full/visible-page is very simple. The only blocker to this has been the UI to actually ask for it to be downloaded.

@johngruen
Copy link
Contributor

@ianb i guess my question is does the proposal that @ChenMorpheus made in the screenshot above look feasible...if you click the invision link, you can see a stepwise version of the same. password = testpilot (password not intended to be cryptographically secure)

@johngruen johngruen modified the milestones: Stretch, Next Tasks Jun 2, 2017
@johngruen
Copy link
Contributor

johngruen commented Jun 2, 2017

From Bugzilla:

https://bugzilla.mozilla.org/show_bug.cgi?id=1368530

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170529030204

Steps to reproduce:

I'm on FF Nightly 55.0a1 (2017-05-29) (64-bit) - It seems as of this release, Firefox Screenshots go straight to the cloud by default?

I work for a large financial organization that takes security very seriously and will not allow Firefox to be installed if this is the default behaviour. (they made me uninstall GreenShot which is open source, but enables uploading to imgur by default).

At the very least, there should be separate build for 'Enterprise' grade installs which disconnect from the cloud completely.

Expected results:

  • Scissor icon should not show
  • If it does show, disable option to upload to the cloud

@fangshih
Copy link

@nihakhanna
Copy link
Collaborator

Thank you! @fangshih

@fangshih
Copy link

Hey @niharikak101
I was thinking for the transition of this view, maybe we can have it with the image fade in ( short ) plus a slight bounce in. Keep it very simple and slick. Thanks! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants