prometheus-unifi-exporter: init at 0.4.0 #23718
Conversation
|
@bachp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @offlinehacker and @bjornfor to be potential reviewers. |
| type = types.bool; | ||
| default = false; | ||
| description = '' | ||
| Do not verify TLS certificate for UniFi Controller API. |
There was a problem hiding this comment.
If I enable this, does it cause verification to happen or not? The description could be more clear on this point.
There was a problem hiding this comment.
Good point I will clarify the documentation on this.
|
For what it's worth, I can't say I'd recommend packaging this exporter. It's something I've worked on in my spare time, but it doesn't do a good job of handling anything about UniFi APs, and there are probably more problems with switches and gateways that I haven't discovered yet. I'm not familiar with NixOS, but I'd recommend that users who are interested just build it themselves. The "releases" only exist for my own configuration management. |
|
@mdlayher I'm using the exporter to monitor my UniFi acces points and it works great so far. I think you did good work and if it doesn't work for somebody chances are that people will contribute and improve the exporter. Also I mainly packaged it because I need it and if it is available via nixpkgs it's just easier for my setup ;) |
|
Makes sense. I happily welcome contributions! |
|
@MostAwesomeDude Documentation clarified |
Motivation for this change
Allow monitoring of Ubiquity unifi access points via prometheus.
/cc @mdlayher
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)