nginx: enableACME should turn on SSL #23713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, why are you using it?
|
@edanaher, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @globin and @fadenb to be potential reviewers. |
|
As I mentioned on #23711, this fix is overly simple and actually probably not a good idea, so I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, why are you using it?
Motivation for this change
Besides the fact that I find it redundant to have to explicitly serve SSL when ACME is enabled (if you're getting an SSL certificate, you presumably want to use it), this should easily resolve #23711, since there won't be an weird configuration with ACME enabled but SSL disabled.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)