Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2_mixer: add optional fluidsynth support #23706

Closed
wants to merge 1 commit into from

Conversation

MP2E
Copy link

@MP2E MP2E commented Mar 10, 2017

also add flac support and mp3 support, and add myself as the maintainer,
since there is no current maintainer for this package

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

also add flac support and mp3 support, and add myself as the maintainer,
since there is no current maintainer for this package
@mention-bot
Copy link

@MP2E, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @cpages and @nckx to be potential reviewers.

@MP2E
Copy link
Author

MP2E commented Mar 16, 2017

merged as of f60fec9

@MP2E MP2E closed this Mar 16, 2017
@MP2E MP2E deleted the sdl2_mixer_update branch March 16, 2017 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants