qt58: init at 5.8.0 #23707
Closed
qt58: init at 5.8.0 #23707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this is merged I'd like to try unifying Qt 5 at least a bit -- this is a good time while latest=default and so we don't have people commiting separate fixes to default and to latest :D I'll do this on Saturday and report if I give up. |
|
Ah, okay then. Let's close this. |
|
ah I've got to check in with staging more it seems. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the -largefiles flag as it's no longer used, the configure scripts were rewritten for qt 5.8. This also means that the iconv flag was removed, as you can only pick icu or iconv now.
I made sure that the qtweb fixes recently introduced were pulled in, and also updated the instructions from 5.7 seeing as they were outdated (5.6 had the correct instructions)
Would like to run this through a full test with nox-review, but I keep hitting unrelated build issues in the tree.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)