Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qbittorrent: 3.3.10 -> 3.3.11 #23703

Merged
merged 1 commit into from Mar 12, 2017
Merged

qbittorrent: 3.3.10 -> 3.3.11 #23703

merged 1 commit into from Mar 12, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Mar 10, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @wkennington and @codyopel to be potential reviewers.

@ndowens
Copy link
Contributor

ndowens commented Mar 10, 2017

Does not build.

Glib enabled.
GTK theme support cannot be enabled due to functionality tests!
Turn on verbose messaging (-v) to ./configure to see the final report.
If you believe this message is in error you may use the continue
switch (-continue) to ./configure to continue.
builder for ‘/nix/store/91vjs9qxpfw8adj9b18zws9c0y06nb8j-qtbase-5.7.1.drv’ failed with exit code 101
cannot build derivation ‘/nix/store/wjcb18i0a4bab64wy728d2xfk0fpiyl6-qbittorrent-3.3.11.drv’: 1 dependencies couldn't be built

@romildo
Copy link
Contributor Author

romildo commented Mar 10, 2017

@ndowens It is qtbase that is failing to build for some reason.

On my system qbittorrent-3.3.11 builds and runs well.

@joachifm joachifm merged commit 196f64d into NixOS:master Mar 12, 2017
@romildo romildo deleted the upd.qbittorrent branch March 12, 2017 19:17
joachifm pushed a commit that referenced this pull request Mar 13, 2017
@romildo @joachifm
qbittorrent: 3.3.10 -> 3.3.11 (#23703)
08381c0 
(cherry picked from commit 196f64d)
Fixes a number of bugs, including some security issues with the
web interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @mention-bot @ndowens @joachifm