Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asterisk: use fetchsvn for vendored library #23124

Closed
wants to merge 1 commit into from
Closed

asterisk: use fetchsvn for vendored library #23124

wants to merge 1 commit into from

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Feb 23, 2017

Motivation for this change
  • fixes asterisk builds on unstable
  • make building more deterministic
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@womfoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @auntieNeo, @DerTim1 and @yorickvP to be potential reviewers.

@yorickvP
Copy link
Contributor

Excellent work!

I was planning on looking into this, my approach would have been to use the 'externals' thing I added. My (probably unfounded) concern now is that different asterisk versions will require different mp3 versions. If this is not a problem, then it looks good to me (but I haven't tested it).

@womfoo
Copy link
Member Author

womfoo commented Feb 24, 2017

Thanks for reviewing this @yorickvP. I've now based my changes around your externals thing. I had to update it to copy directories over and loosen up the permissions (can't compile with a directories of mode 555). Let me know if you need me to change anything.

DerTim1
DerTim1 approved these changes Feb 28, 2017
View reviewed changes
Copy link

@DerTim1 DerTim1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@DerTim1 DerTim1 mentioned this pull request Mar 1, 2017
Closed
50 tasks
@grahamc
Copy link
Member

grahamc commented Mar 6, 2017

Applied in ac61dde, thank you!

@grahamc grahamc closed this Mar 6, 2017
vcunat pushed a commit that referenced this pull request Mar 12, 2017
@womfoo @vcunat
asterisk: use fetchsvn for vendored library
e47b819 
(cherry picked from commit ac61dde)
/cc #23124, #23253.  It failed to build otherwise.
@womfoo womfoo deleted the fix/asterisk-build branch April 30, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@DerTim1 DerTim1 DerTim1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@womfoo @mention-bot @yorickvP @grahamc @fpletz @DerTim1