pythonPackages.pepper: init at 0.5.0 #23640
Conversation
pkgs/top-level/python-packages.nix
Outdated
| @@ -8751,6 +8751,8 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| pepper = callPackage ../development/python-modules/pepper { }; | |||
There was a problem hiding this comment.
judging from the description this is an application and not a package. Therefore, it should be called from all-packages.nix.
There was a problem hiding this comment.
@FRidh done. Thanks for the info.
There was a problem hiding this comment.
... and the file also shouldn't be in python-modules. Please check the current version of the manual (nix-build doc) for the guidelines on Python packages.
There was a problem hiding this comment.
@FRidh I can put it on pkgs/tools/admin/pepper/default.nix or pkgs/tools/admin/salt/pepper.nix. The second one looks best to me (but I would actually have create a "saltstack" repo instead of "salt). What do you think ?
There was a problem hiding this comment.
@FRidh That said, it is a bit weird to have ansible in a complete different place ...
There was a problem hiding this comment.
@PierreR I'm fine with any really, I don't know what would be best there. Anyway, ansible is an unfortunate case.
There was a problem hiding this comment.
@FRidh I have eventually opted for pkgs/tools/admin/salt/pepper which seems good enough. I have also replaced buildPythonPackage with buildPythonApplication.
As a note, I don't know how to find out the proper mirror://pypi/ (but github releases works well enough).
| meta = { | ||
| description = "A CLI front-end to a running salt-api system"; | ||
| homepage = https://github.com/saltstack/pepper; | ||
| license = lib.licenses.asl20; |
There was a problem hiding this comment.
Do you want to maintain this package?
There was a problem hiding this comment.
@Mic92 yes I can maintain the package.
There was a problem hiding this comment.
Ok, in that case please add a reference for your github username in lib/maintainers.nix and a reference it in this package like:
meta = with stdenv.lib; {
# ...
maintainers = [ maintainers.pierrer ];
};
There was a problem hiding this comment.
@Mic92 @FRidh Sorry to bother you both with this again but I am wondering if salt-pepper is not a better name for the attribute in all-packages. I am not sure what is the most idiomatic between pepper, salt_pepper or salt-pepper. The executable is named 'pepper' and the python package is named 'salt-pepper'.
|
Thanks! |
Motivation for this change
Add missing
pepperpython packageThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)