Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skim: init at 1.4.28 #23630

Closed
wants to merge 2 commits into from

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Mar 8, 2017

Motivation for this change

Skim is a great PDF reader for macOS, so why not have a Nix package for it?

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg dezgeg added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Mar 9, 2017
@rasendubi
Copy link
Member

It is better to build the package from source rather than download pre-built binary.

@yurrriq
Copy link
Member Author

yurrriq commented Mar 10, 2017

@rasendubi: Ok, I've always downloaded binaries, but I'll give it a go.

Edit: Couldn't get it sorted with Nix. Are there any good examples out there of building Xcode projects? I couldn't seem to find any. I managed to break my /nix/store, so I won't be trying again any time soon.

@yurrriq yurrriq changed the title skim: init at 1.4.27 [WIP] skim: init at 1.4.27 Mar 10, 2017
@yurrriq yurrriq changed the title [WIP] skim: init at 1.4.27 skim: init at 1.4.27 Mar 10, 2017
@yurrriq yurrriq force-pushed the add/pkgs/applications/misc/skim branch from 2f48b4a to 9c3f661 Compare May 26, 2017 18:28
@yurrriq yurrriq changed the title skim: init at 1.4.27 skim: init at 1.4.2 May 26, 2017
@yurrriq yurrriq changed the title skim: init at 1.4.2 skim: init at 1.4.28 May 26, 2017
@yurrriq
Copy link
Member Author

yurrriq commented May 26, 2017

I've rebased this and upgraded to 1.4.28. I have no intentions of building from source any time soon. Feel free to merge or close.

@yurrriq yurrriq closed this Oct 8, 2017
@yurrriq yurrriq deleted the add/pkgs/applications/misc/skim branch October 8, 2017 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants