-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixpkgs: build aarch64-linux #23638
nixpkgs: build aarch64-linux #23638
Conversation
@grahamc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @domenkozar and @peti to be potential reviewers. |
We also need a build machine for hydra if we merge this PR or those builds will stay in the queue. Can we get this done simultaneously? |
Oh, nevermind. Thanks a lot. 👍 |
The beast won't be idle anymore! |
Looks good to me (code-wise). What's missing? :) |
Hm, it's giving eval errors apparently for all aarch64 jobs:
https://hydra.nixos.org/jobset/nixpkgs/trunk/#tabs-errors This is odd because the patchelf jobset evaluated fine with an aarch64 job: http://hydra.nixos.org/build/49825197 |
We also need to update https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/release-lib.nix#L33 |
This has been merged 11 days ago but one of the jobs, Thunderbird, hasn't actually ever been build successfully. It's nice having aarch64 support but I don't think aarch64 builds should block any of the channels. There's too few people having such systems / the possibility to fix issues. |
Certainly not my intention. I'm sorry. Can we still build it, but not
depend on it passing?
…On Sun, Mar 19, 2017 at 5:46 PM Frederik Rietdijk ***@***.***> wrote:
This has been merged 11 days ago but one of the jobs, Thunderbird, hasn't
actually ever been build successfully. It's nice having aarch64 support but
I don't think aarch64 builds should block any of the channels. There's too
few people having such systems / the possibility to fix issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23638 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAErrC3_ZviiYMxYykCb8TYt9ormk8Ezks5rnaJDgaJpZM4MW09w>
.
|
Done in 93446a2. |
cc @dezgeg @edolstra
I figure we'll start with nixpkgs and expand to NixOS afterwards.