verilator: fix Perl shebangs #23631
Merged
verilator: fix Perl shebangs #23631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edef1c, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin and @thoughtpolice to be potential reviewers. |
|
without this fix, it relies on bash interpreting things without a shebangs as bash scripts, which not only breaks under non-bash shells, but also breaks anything just |
Mic92
reviewed
Mar 9, 2017
| @@ -12,6 +12,10 @@ stdenv.mkDerivation rec { | |||
| enableParallelBuilding = true; | |||
| buildInputs = [ perl flex_2_6_1 bison ]; | |||
|
|
|||
| postInstall = '' | |||
| sed -i -e '3a\#!/usr/bin/env perl' -e '1,3d' $out/bin/{verilator,verilator_coverage,verilator_profcfunc} | |||
There was a problem hiding this comment.
would
sed -i -e '3a\#!/${pkgs}/bin/perl' -e '1,3d' $out/bin/{verilator,verilator_coverage,verilator_profcfunc}
also work here?
There was a problem hiding this comment.
the fixup phase handles this already, the /usr/bin/env usage never makes it into the final build
|
Thanks! |
|
I guess we have the same bug in our |
|
Probably. This should cherry-pick cleanly though? |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)