haskell ghc710x packages fixes #23252
Conversation
ljli
force-pushed
the
ghc7103-pkgs-fixes
branch
from
f3bfc4c to
114a15f
Compare
| @@ -42,6 +42,10 @@ self: super: { | |||
| # Build jailbreak-cabal with the latest version of Cabal. | |||
| jailbreak-cabal = super.jailbreak-cabal.override { Cabal = self.Cabal_1_24_2_0; }; | |||
|
|
|||
| gtk2hs-buildtools = super.gtk2hs-buildtools.override { Cabal = self.Cabal_1_24_2_0; }; | |||
There was a problem hiding this comment.
Why do you consider Cabal a build tool? Is it not a Haskell dependency?
There was a problem hiding this comment.
Cabal is itself a cabal package available on hackage. GHC pins a specific version on each release and distributes it among its boot packages. gtk2hs-buildtools requires a newer major version of Cabal than the one that is pinned by GHC 7.10.x (that would be 1.22.x.x). For that reason the package fails to build at present, supplying the newer Cabal dependency fixes it.
There was a problem hiding this comment.
Ah, okay. Sorry, I misread your patch, actually, and misunderstood the change. Thank you for the explanation.
| @@ -182,6 +186,9 @@ self: super: { | |||
| # https://github.com/well-typed/hackage-security/issues/158 | |||
| hackage-security = dontHaddock (dontCheck super.hackage-security); | |||
|
|
|||
| # Fixed in 1.0.5, remove if stackage and configuration-hackage2nix.yaml catched up | |||
There was a problem hiding this comment.
That happens within a week or less. Is it okay to avoid adding this override temporarily for such a short period of time?
There was a problem hiding this comment.
That's reasonable, I'll update the PR accordingly.
ljli
force-pushed
the
ghc7103-pkgs-fixes
branch
from
114a15f to
1a4ec41
Compare
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)