add 006-classic-analog watchface #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I have some time again, I will also fix the wrong drop shadow. ;) |
|
Good job anyc. I like your work but I have two requests:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on 001-analog, I added small hours and minute marks and a seconds hand. For the additional hand, I changed the update frequency to "seconds". I do not know, however, if this has any negative implications.
It is not my favorite watchface but I think it would serve well as an example for a more classic look.
By the way, I do not know if this was intentional, but in this watchface I removed the ctx.closePath() calls as they made the hand longer if I just increased the lineWidth. This was a bit suprising to me. Without, the lineWidth and the hand length act more predictable.