Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tpm-quote-tools: 1.0.2 -> 1.0.3 #23351

Merged
merged 1 commit into from Mar 9, 2017
Merged

tpm-quote-tools: 1.0.2 -> 1.0.3 #23351

merged 1 commit into from Mar 9, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 1, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017

tpm_mkaik seems to miss a openssl reference:

tpm_mkaik: error while loading shared libraries: libcrypto.so.1.0.0: cannot open shared object file: No such file or directory

@ndowens
Copy link
Contributor Author

ndowens commented Mar 2, 2017 •
edited

don't understand why when OpenSSL is in the dep list

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017 •
edited

@ndowens openssl is probably loaded via dlopen. In this case LD_LIBRARY_PATH needs to be extended to include openssl. UPDATE it is dynamically linked:

$ ldd ./tpm_mkaik
        linux-vdso.so.1 (0x00007ffc1e0d7000)
        libtspi.so.1 => /nix/store/vyg7f3fa4lb73c4nwjzkjqninvh6cv5d-trousers-0.3.13/lib/libtspi.so.1 (0x00007fe698601000)
        libc.so.6 => /nix/store/a5gvhlwrday3dj8z3v09nr65ngn5jzq3-glibc-2.25/lib/libc.so.6 (0x00007fe698262000)
        libcrypto.so.1.0.0 => not found
        libpthread.so.0 => /nix/store/a5gvhlwrday3dj8z3v09nr65ngn5jzq3-glibc-2.25/lib/libpthread.so.0 (0x00007fe698044000)
        libcrypto.so.1.0.0 => /nix/store/b9nf47v92wm21vjr1yids22wqgwykxbw-openssl-1.0.2k/lib/libcrypto.so.1.0.0 (0x00007fe697c08000)
        libssl.so.1.0.0 => /nix/store/b9nf47v92wm21vjr1yids22wqgwykxbw-openssl-1.0.2k/lib/libssl.so.1.0.0 (0x00007fe69799a000)
        libgcc_s.so.1 => /nix/store/a5gvhlwrday3dj8z3v09nr65ngn5jzq3-glibc-2.25/lib/libgcc_s.so.1 (0x00007fe697784000)
        /nix/store/a5gvhlwrday3dj8z3v09nr65ngn5jzq3-glibc-2.25/lib/ld-linux-x86-64.so.2 (0x00007fe69886f000)
        libdl.so.2 => /nix/store/a5gvhlwrday3dj8z3v09nr65ngn5jzq3-glibc-2.25/lib/libdl.so.2 (0x00007fe697580000

@ndowens
tpm-quote-tools: 1.0.2 -> 1.0.3
40fb613 
tpm-quote-tools: Fixed library issue
@grahamc
Copy link
Member

grahamc commented Mar 6, 2017

@Mic92 can you re-check?

@ndowens
Copy link
Contributor Author

ndowens commented Mar 9, 2017

Doesn't give error for me now

➜ nixpkgs git:(master) /nix/store/z1q4g895d52kxkbwrah4rgsjlxmvb15g-tpm-quote-tools-1.0.3/bin/tpm_mkaik
Usage: /nix/store/z1q4g895d52kxkbwrah4rgsjlxmvb15g-tpm-quote-tools-1.0.3/bin/tpm_mkaik [options] blob pubkey
Options:
-z Use well known secret used as owner secret
-u Use TSS UNICODE encoding for passwords
-h Display command usage info
-v Display command version info

On success, creates an attestation identity key in blob
and a DER-encoded public key in pubkey.
➜ nixpkgs git:(master) /nix/store/z1q4g895d52kxkbwrah4rgsjlxmvb15g-tpm-quote-tools-1.0.3/bin/tpm_mkaik -v
TPM Quote Tools 1.0.3

@Mic92 Mic92 merged commit a1d6e74 into NixOS:master Mar 9, 2017
@Mic92
Copy link
Member

Mic92 commented Mar 9, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ndowens @Mic92 @grahamc @joachifm