Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcapc: 2015-03.06 -> 1.0.0 #23360

Merged
merged 1 commit into from Mar 24, 2017
Merged

pcapc: 2015-03.06 -> 1.0.0 #23360

merged 1 commit into from Mar 24, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 2, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017

How to use this package? I tried the example from the homepage:

$ tc filter add dev enp0s25 parent 1: bpf run bytecode "$(pcapc dst port 22)" flowid 1:10
RTNETLINK answers: Invalid argument
We have an error talking to the kernel

@ndowens
Copy link
Contributor Author

ndowens commented Mar 2, 2017

@Mic92 not sure. Just updating packages in repo that is old. I think I tried tc ip and it worked, atleast didn't segfault or anything

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017

@ndowens can you check, if it did?

@ndowens
Copy link
Contributor Author

ndowens commented Mar 2, 2017 via email

@ndowens
Copy link
Contributor Author

ndowens commented Mar 3, 2017

@Mic92 :
➜ z2saf8i2snnhw1jhgvccr8420267im7q-pcapc-1.0.0 ./bin/pcapc ip and dst host 8.8.8.8 and dst port 53 and udp

results in:

15,40 0 0 12,21 0 12 2048,32 0 0 30,21 0 10 134744072,48 0 0 23,21 8 0 132,21 7 0 6,21 0 6 17,40 0 0 20,69 4 0 8191,177 0 0 14,72 0 0 16,21 0 1 53,6 0 0 4294967295,6 0 0 0,%

on the tc filter, I am unsure what is wrong with it? I installed the older version, it gives me the same error as well

@ndowens
Copy link
Contributor Author

ndowens commented Mar 22, 2017

@Mic92 do you think it is ok to merge when older version does the same thing?

@7c6f434c
Copy link
Member

@nckx Let me be a mention-bot for a while…

I think that if there is a bug which is not a regression, this shouldn't prevent the update.

@nckx
Copy link
Member

nckx commented Mar 24, 2017

@7c6f434c: I think that if there is a bug which is not a regression, this shouldn't prevent the update.

Absolutely. This package used to work for me™, but don't ask me why or when (it was long ago). I think it's time for a patch to unmaintain such packages.

@ndowens: why the change to the home page? (It's fine; I'm just a curious fellow.)

@nckx nckx merged commit ef69326 into NixOS:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants