Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horst: git-2016-03-15 -> 5.0 #23370

Merged
merged 1 commit into from Mar 6, 2017
Merged

horst: git-2016-03-15 -> 5.0 #23370

merged 1 commit into from Mar 6, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 2, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017

Seems to start, but I cannot get it working with my intel wifi card,
so I cannot tell whether it actually works.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 2, 2017 via email

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@grahamc
Copy link
Member

grahamc commented Mar 6, 2017

@matthiasbeyer can you describe how you tested it? I'm not sure how.

@matthiasbeyer
Copy link
Contributor

Compiled the package from this PR and started it... I was able to see output that looked sane...

@Mic92 Mic92 merged commit af27d6e into NixOS:master Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants