👍

@bramswenson do you want to make the changes? because if I would require access to your fork/branch.

@marceloboeira @RX14 Done! Thanks!

@bramswenson great!

@bramswenson Thank you for this!

In general the PR looks very good. However:

• I'm not sure about adding Dir.rm_r. In general we have simple methods in File and Dir, and more complex methods in FileUtils. FileUtils has methods that you can find in bash, like rm_r or mkdir_p.
• I'm also not sure about Dir.tmpdir, but I think it's OK (similar to Ruby, related to Dir and not Tempfile), but this is a small breaking change and we should note it.

I'm all the time unsure about File, Dir, FileUtils and where to put things. Maybe things are too complex/messy right now. I'll discuss this with the team, maybe we can just put all methods in File and Dir and remove FileUtils.

For now we can merge your change if it doesn't introduce breaking changes (Use Tmpfile.dirname instead of Dir.tmpdir and keeps FileUtils.rm_r instead of Dir.rm_r)). That's at least if we want this included in the next patch release.

@asterite Thanks for the kind words, but I did nothing but the rebase to master out of selfish desire to use this feature ;) @marceloboeira Did the actual work and there was reasonable discussion about the move between Dir and FileUtils in #2911 between @marceloboeira and @RX14. I really don't have a dog in that fight and will be happy to see the feature wherever you all decide is most appropriate. Thanks!

I will say that the removal of FileUtils in preference for File and Dir makes sense to me. I also think these methods should closely resemble their unix counterparts in naming as unix file modification executable names are common knowledge (or should be). But that is just my 2 cents.

I didn't have time to take a look at the comments yet folks, but I will do it soon. @bramswenson thanks for the invitation to your repository and the efforts on making it happen. 👍

I was about to (suggest to) add this!
@bramswenson, will you work on this anytime soon ? (I'd really like something like that to refactor some compiler specs)

About naming I was thinking, since we already have the Tempfile class, we could have Tempdir ?
And put the two in a Temporary module with a simple API like:

Temporary::File.new # gives a file
Temporary::Dir.new # gives a dir

Temporary::Dir.open do |dir|
  # do something with the `dir`
  puts dir.path
end # the block ensures that the temp dir is deleted

Temporary.create_name("foo.XXX") # gives a (file/dir)name following a pattern

# etc..

I think we shouldn't have "tempdir" and "tempfile" classes, just methods on Dir and File which create tempoary versions of themselves. Why does Tempfile currently not inherit File? It makes little sense to me.

Why does Tempfile currently not inherit File? It makes little sense to me.

I thought the same.

@RX14 any updates here?

@marceloboeira Tempfile was removed in #6485. We still need to decide what to do about FileUtils, I say that most of it's methods belong on Path once that is merged.

Too old, I think should be closed now. A new PR can be opened if wanted.

As now, to create a temp dir:

dir = File.tempname 
Dir.mkdir dir
begin
  # do things
ensure
  FileUtils.rm_rf dir
end