ocproxy: 1.50 -> 1.60 #23368
Closed
ocproxy: 1.50 -> 1.60 #23368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @Joko |
matthiasbeyer
approved these changes
Mar 5, 2017
|
Meanwhile, 1.70 has been released. Per https://github.com/cernekee/ocproxy/blob/master/CHANGES the 1.50->1.70 delta looks pretty safe. |
|
Update it as soon as I can
…Sent from my iphone
On Mar 5, 2017, 2:56 PM -0600, Joachim F. ***@***.***>, wrote:
Meanwhile, 1.70 has been released. Per https://github.com/cernekee/ocproxy/blob/master/CHANGES the 1.50->1.70 delta looks pretty safe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (#23368 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL76MTSa_OrkPWbN6ZO5JhtKPzrxoXks5riyGYgaJpZM4MQZ7z).
|
grahamc
reviewed
Mar 6, 2017
| }; | ||
|
|
||
| buildInputs = [ autoconf automake libevent ]; | ||
|
|
There was a problem hiding this comment.
Just a heads up, there is some whitespace on the end of this line that doesn't need to be there. I fixed it for you :) Depending on your editor, it may have a plugin called "EditorConfig" which will do this automatically.
|
Merged in 3686e1b, thank you! Put in another PR for the 1.70 when you get a chance. |
|
@grahamc as soon as I can 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)