Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniupnpc: 1.9.20150430 -> 2.0.20161216 #23367

Merged
merged 1 commit into from Mar 2, 2017
Merged

miniupnpc: 1.9.20150430 -> 2.0.20161216 #23367

merged 1 commit into from Mar 2, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 2, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit e867620 into NixOS:master Mar 2, 2017
@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017

Thanks!

@joachifm
Copy link
Contributor

joachifm commented Mar 2, 2017

@ndowens some of the *coin expect the old API and so are broken by this update, with errors like

net.cpp:1056:74: error: too few arguments to function 'UPNPDev* upnpDiscover(int, const char*, const char*, int, int, unsigned char, int*)'
In file included from net.cpp:28:0:
/nix/store/00xp62amp49x5ypigbpamzqm90jz6707-miniupnpc-2.0.20161216/include/miniupnpc/miniupnpc.h:62:1: note: declared here
upnpDiscover(int delay, const char * multicastif,

https://hydra.nixos.org/build/49668169/nixlog/1/raw

If it can't be fixed by updating the failing packages, perhaps we could add a miniupnpc-1 package.

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017

I will fix the coin packages, eiskaltdcpp is also broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndowens @Mic92 @joachifm