Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANTs: init at 2.1.0 (0gyys1lf) and update ITK accordingly #23376

Merged
merged 2 commits into from Mar 18, 2017

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 2, 2017

Motivation for this change

added ANTs and built ITK with appropriate VTK-related options. Also enabled MINC support.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

bcdarwin commented Mar 2, 2017

Note that ITK now depends on VTK, which could be made optional if necessary.

@bcdarwin
Copy link
Member Author

bcdarwin commented Mar 3, 2017

Looks like seg3d failed to build but it's already doing so for the same reason (-Werror=format-security) in trunk.

@joachifm
Copy link
Contributor

joachifm commented Jul 1, 2017

Looks like this will attempt to access the network during the build, thus failing if the sandbox is enabled: https://hydra.nixos.org/build/54976336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants