Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fakeroot: add darwin support #23380

Merged
merged 1 commit into from Mar 2, 2017
Merged

fakeroot: add darwin support #23380

merged 1 commit into from Mar 2, 2017

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 2, 2017 •
edited

replace utillinux with getopt

Fixes #22773

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl
fakeroot: add darwin support
82d3f92 
replace utillinux with getopt

Fixes NixOS#22773
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Mar 2, 2017
@domenkozar
Copy link
Member

cc @copumpkin

@LnL7 LnL7 merged commit cd92980 into NixOS:master Mar 2, 2017
@veprbl veprbl deleted the fakeroot_darwin branch December 1, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @domenkozar @LnL7