mkDerivation: Don't pass buildInputs to stdenv builder in nativeBuildInputs #23374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Inputs When not cross compiling, nativeBuildInputs and buildInputs have identical behaviour. Currently that is implemented by having mkDerivation do a concatenation of those variables in Nix code and pass that to the builder via the nativeBuildInputs attribute. However, that has some annoying side effects, like `foo.buildInputs` evaluating to `[ ]` even if buildInputs were specified in the nix expression for foo. Instead, pass buildInputs and nativeBuildInputs in separate variables as usual, and move the logic of cross compilation vs. native compilation to the stdenv builder script. This is probably a tiny bit uglier but fixes the previous problem. Issue NixOS#4855.
vcunat
approved these changes
Apr 14, 2017
vcunat
added a commit
that referenced
this pull request
Apr 14, 2017
Don't pass buildInputs to stdenv builder in nativeBuildInputs.
8 tasks
Ericson2314
added a commit
to obsidiansystems/nixpkgs
that referenced
this pull request
Nov 21, 2017
This continues NixOS#23374, which always kept around both attributes, by always including both propagated files: `propgated-native-build-inputs` and `propagated-build-inputs`. `nativePkgs` and `crossPkgs` are still defined as before, however, so this change should only barely observable. This is an incremental step to fully keeping the dependencies separate in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way of solving the biggest problem described in #4855.
This does not rename anything and (at least doesn't intend to) change anything wrt. how the semantics of
buildInputsandnativeBuildInputswork inside the builder script. But it does solve the problem offoo.buildInputs(orecho $buildInputsin a nix-shell) giving an unexpected result.Needs a bit more testing, but in case this doesn't cause major breakage I'd propose this for 17.03. The reason for that being the new
overrideAttrsfunction we merged earlier, which gets rid of another well-knownbuildInputsvsnativeBuildInputswart when usingoverrideDerivation.cc @edolstra