Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: Use CA bundle in nix default profile by default #23723

Merged
merged 1 commit into from Mar 11, 2017

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 10, 2017

@mention-bot
Copy link

@shlevy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @ikervagyok and @vcunat to be potential reviewers.

@shlevy
Copy link
Member Author

shlevy commented Mar 10, 2017

If this is acceptable I'd like to get it in 16.09 and 17.03 as well

@copumpkin
Copy link
Member

Why would NixOS releases make a difference to Darwin stuff? Otherwise it looks fine

@shlevy
Copy link
Member Author

shlevy commented Mar 10, 2017

@copumpkin Because we have some users who use those as stable nix channels.

@LnL7
Copy link
Member

LnL7 commented Mar 10, 2017

I hope not, I thought that darwin fixes where never ported to release branches.

@shlevy
Copy link
Member Author

shlevy commented Mar 10, 2017

OK, I'll tell them to switch to unstable

@domenkozar
Copy link
Member

Doesn't this collide with @edolstra patch at #23605

@shlevy
Copy link
Member Author

shlevy commented Mar 10, 2017

Not really, no. This is for cases where the env var isn't set at all. If it is, nix indeed overrides the default cert path already.

@domenkozar
Copy link
Member

So this is for the cases when Nix profile is not sourced? Makes sense. But we'd need to patch git, etc as well then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants