-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug in the transition to nonvanishing intrinsic acceleration #1240
Conversation
This reverts commit 1ccfd58.
ksp_plugin/pile_up.cpp
Outdated
@@ -152,6 +152,10 @@ void PileUp::AdvanceTime( | |||
last_point_is_authoritative = false; | |||
} | |||
} else { | |||
// We make the existing last point authoritative, i.e. we do not remove it. | |||
// If it was already authoritative nothing happen, if it was not, we |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happens
ksp_plugin_test/pile_up_test.cpp
Outdated
using quantities::si::Kilogram; | ||
using quantities::si::Micro; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetize.
ksp_plugin_test/pile_up_test.cpp
Outdated
TEST_F(PileUpTest, MidStepIntrinsicForce) { | ||
// An empty ephemeris; the parameters don't matter, since there are no bodies | ||
// to integrate. | ||
// TODO(egg): ... except we have to put a body because |Ephemeris| doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/TODO/NOTE/
No description provided.