Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in the transition to nonvanishing intrinsic acceleration #1240

Merged
merged 10 commits into from
Mar 10, 2017

Conversation

eggrobin
Copy link
Member

No description provided.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
This reverts commit 92b6dc5.
@pleroy pleroy added the LGTM label Mar 10, 2017
@@ -152,6 +152,10 @@ void PileUp::AdvanceTime(
last_point_is_authoritative = false;
}
} else {
// We make the existing last point authoritative, i.e. we do not remove it.
// If it was already authoritative nothing happen, if it was not, we
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happens

using quantities::si::Kilogram;
using quantities::si::Micro;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize.

TEST_F(PileUpTest, MidStepIntrinsicForce) {
// An empty ephemeris; the parameters don't matter, since there are no bodies
// to integrate.
// TODO(egg): ... except we have to put a body because |Ephemeris| doesn't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/TODO/NOTE/

@pleroy pleroy merged commit d6dd2f8 into mockingbirdnest:Cardano Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants