Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcachegrind: init at 2017-02-25 #23721

Closed
wants to merge 1 commit into from
Closed

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Mar 10, 2017

Motivation for this change

This adds KCachegrind. There is another branch of KCachegrind in KDE Applications Bundle, but it requires KDE 4 (unlike the master branch that requires KDE 5) and is not available in Nixpkgs.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

Why not use the latest release? It's quite fresh. (We really shouldn't package development snapshots.)

@orivej
Copy link
Contributor Author

orivej commented Mar 10, 2017

Although KCacheGrind has been ported to KDE 5 in 2014, it does not seem to have ever been released. The latest release, v16.12.3, is still for KDE 4.

@orivej
Copy link
Contributor Author

orivej commented Mar 11, 2017

@ttuegel You might want to review this.

@ttuegel
Copy link
Member

ttuegel commented Mar 11, 2017

Although KCacheGrind has been ported to KDE 5 in 2014, it does not seem to have ever been released. The latest release, v16.12.3, is still for KDE 4.

It is based on kdelibs4, but that does not mean it is for KDE 4. Please use the version in KDE Applications 16.12. Upstream will update the package as necessary before they remove kdelibs4 in KDE Applications 17.12.

@ttuegel ttuegel closed this Mar 11, 2017
@orivej
Copy link
Contributor Author

orivej commented Mar 11, 2017

OK, here is kcachegrind with kdelibs: #23766

@orivej orivej deleted the kcachegrind branch March 18, 2017 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants