Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: 0.35.0 -> 0.39.0 #23725

Closed
wants to merge 1 commit into from
Closed

Conversation

thomastjeffery
Copy link

@thomastjeffery thomastjeffery commented Mar 10, 2017

Motivation for this change

Simple update from 0.35.0 to 0.39.0.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@thomastjeffery, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sternenseemann, @rasendubi and @brandonedens to be potential reviewers.

@ndowens
Copy link
Contributor

ndowens commented Mar 10, 2017

I get error:

source root is libhttpseverywhere-0.2.3
setting SOURCE_DATE_EPOCH to timestamp 1477361792 of file libhttpseverywhere-0.2.3/test/main.vala
patching sources
configuring
100 256 100 256 0 0 605 0 --:--:-- --:--:-- --:--:-- 606

/nix/store/nmzimmm6awzjl8czr17c8fmrdikhw0ma-stdenv/setup: line 884: meson.py: command not found
builder for ‘/nix/store/pqs3sh2fjmllv4v7748zwlwwwyns38xp-libhttpseverywhere-0.2.3.drv’ failed with exit code 127
error: build of ‘/nix/store/pqs3sh2fjmllv4v7748zwlwwwyns38xp-libhttpseverywhere-0.2.3.drv’ failed
The invocation of "nix-build -A libhttpseverywhere -A meson -A pitivi /home/ndowens/.nox/nixpkgs" failed

@thomastjeffery
Copy link
Author

Looks like there is an issue in libhttpseverywhere/default.nix

meson.py --prefix "$out" ..

First "meson.py" needs to be changed to "meson". After that I see that meson-0.39.0 does not let you use absolute paths. How can we get a relative path from $out?

@ndowens
Copy link
Contributor

ndowens commented Mar 10, 2017

hmm weird, nix-build -A meson works w/o error just not nox-review

May be fine after all, maybe someone else can verify this

@thomastjeffery
Copy link
Author

Upgrading meson worked without issue, but it broke the build script for libhttpseverywhere.

For some reason, I get this error when running

nix-build -A meson -A libhttpseverywhere

Meson encountered an error in file meson.build, line 56, column 0:
Tried to form an absolute path to a source dir. You should not do that but use
relative paths instead.

To get include path to any directory relative to the current dir do

incdir = include_directories(dirname)

After this incdir will contain both the current source dir as well as the
corresponding build dir. It can then be used in any subdirectory and
Meson will take care of all the busywork to make paths work.

Dirname can even be '.' to mark the current directory. Though you should
remember that the current source and build directories are always
put in the include directories by default so you only need to do
include_directories('.') if you intend to use the result in a
different subdirectory.

I'm not sure how to fix this without changing the downloaded meson.build explicitly.

@ndowens
Copy link
Contributor

ndowens commented Mar 10, 2017

Looks like libhttpseverywhere needs to be updated too

@thomastjeffery
Copy link
Author

True. Unfortunately that doesn't solve the problem either.

If you do want to update libhttpseverywhere, change

minor = "3";

to

minor = "10";

and the sha256 to

sha256 = "235f5b7f96188d800470871774e31696fbde085b63f65bd71434af8e9e6ac8aa";

@ndowens
Copy link
Contributor

ndowens commented Mar 10, 2017

Opening PR for the update for libhttpseverywhere #23728

@thomastjeffery
Copy link
Author

thomastjeffery commented Mar 10, 2017

I ran

nix-env -f . -iA meson

to install meson. Now how do I uninstall it?
It doesn't seem to be listed by

nix-env -q

EDIT: It was masquerading as python3.5-meson

@ndowens
Copy link
Contributor

ndowens commented Mar 10, 2017

nix-env -e meson maybe

@ndowens
Copy link
Contributor

ndowens commented Mar 20, 2017

Does this still give error for you now?

@ndowens
Copy link
Contributor

ndowens commented Mar 23, 2017

Updated libhttpseverywhere #24255 hoping this fixes this build issue

@7c6f434c
Copy link
Member

@thomastjeffery master now has 0.40, is it OK to close this?

@thomastjeffery
Copy link
Author

Looks good. Thanks for the update.

@7c6f434c
Copy link
Member

7c6f434c commented May 1, 2017

It's not even me who did the update, I was just triaging these two days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants