Add service for glances #23266
Add service for glances #23266
Conversation
|
@matthiasbeyer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
|
Hi, The service has options to enable or disable many capabilities of glances. However, some of them only makes sense if Maybe the options should be limited to the ones that only change something? |
|
@lsix thanks for pointing this out. I will continue to work on this, so that if a certain switch is enabled, the appropriate dependencies of glances are built into the package. So, this is WIP, don't merge please! 🛩️ |
|
The commits I just pushed are not tested, but I ask for review here, whether this approach is a good idea or not... |
|
I don't know much about glances, but if you think it makes sense to have a service, go ahead, implement it and maintain it. Just don't get too ambitious with all the options. Also think about whether it makes sense or not to add optional dependencies to the |
|
Status update? |
|
No time atm, but I will rebase to fix merge issues, so others can pick it up easily. Will continue as soon as I have enough free time. |
These two flags do not work as expected. I would expect to be able to
pass a parameter to them like so:
glances --username user --password kittensAreCute
but they do not take any parameters. Therefor, disable them.
matthiasbeyer
force-pushed
the
glances-service
branch
from
2c3b6b3
to
995955c
Compare
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)I rudimentarily tested the service on my local device.
The
usernameandpassworddo not work as expected, will shortly push a commit to disable these options.